[PATCH] ath10k: remove an unnecessary NULL check

[Dan Carpenter]

The "survey" pointer is the address of an array element. We know that
it can't be NULL so this check can be removed.

Signed-off-by: Dan Carpenter <***@oracle.com>
---
drivers/net/wireless/ath/ath10k/wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index 659513bf4ddc..6a04727b63ce 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -2578,7 +2578,7 @@ static void ath10k_wmi_event_chan_info_unpaired(struct ath10k *ar,

survey = &ar->survey[idx];

- if (!params->mac_clk_mhz || !survey)
+ if (!params->mac_clk_mhz)
return;

memset(survey, 0, sizeof(*survey));

[Kalle Valo]

Post by Dan Carpenter
The "survey" pointer is the address of an array element. We know that
it can't be NULL so this check can be removed.
---
drivers/net/wireless/ath/ath10k/wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index 659513bf4ddc..6a04727b63ce 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -2578,7 +2578,7 @@ static void ath10k_wmi_event_chan_info_unpaired(struct ath10k *ar,
survey = &ar->survey[idx];
- if (!params->mac_clk_mhz || !survey)
+ if (!params->mac_clk_mhz)
return;

Can you please CC linux-wireless so that patchwork sees this?

[Dan Carpenter]

Post by Kalle Valo

Post by Dan Carpenter
The "survey" pointer is the address of an array element. We know that
it can't be NULL so this check can be removed.
---
drivers/net/wireless/ath/ath10k/wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index 659513bf4ddc..6a04727b63ce 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -2578,7 +2578,7 @@ static void ath10k_wmi_event_chan_info_unpaired(struct ath10k *ar,
survey = &ar->survey[idx];
- if (!params->mac_clk_mhz || !survey)
+ if (!params->mac_clk_mhz)
return;

Can you please CC linux-wireless so that patchwork sees this?

Sure. I can resend.

regards,
dan carpenter

[Dan Carpenter]

The "survey" pointer is the address of an array element. We know that
it can't be NULL so this check can be removed.

Signed-off-by: Dan Carpenter <***@oracle.com>
---
Resending with linux-wireless Cc for patchwork.

drivers/net/wireless/ath/ath10k/wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index 659513bf4ddc..6a04727b63ce 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -2578,7 +2578,7 @@ static void ath10k_wmi_event_chan_info_unpaired(struct ath10k *ar,

survey = &ar->survey[idx];

- if (!params->mac_clk_mhz || !survey)
+ if (!params->mac_clk_mhz)
return;

memset(survey, 0, sizeof(*survey));